Michael Blow has posted comments on this change. Change subject: [NO ISSUE][STO] Perform IO reads in uninterruptible threads ......................................................................
Patch Set 4: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/2387/4/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: PS4, Line 719: while (true) { let's set the name on this thread PS4, Line 725: Reader thread - " + num + " the number can be in the thread name, which gets logged- can we just use {} ...., this here? PS4, Line 726: Thread.currentThread().interrupt(); I think we should ignore any interrupt here, and update log message accordingly PS4, Line 733: "Reader thread - " + num : + " same comment above on name, etc. PS4, Line 740: BufferCache reader thread - " + num + " same comment above on name PS4, Line 749: "Reader thread - " + num + " same comment above on name PS4, Line 889: // NOSONAR will always succeed since the queue is empty why is the queue empty? https://asterix-gerrit.ics.uci.edu/#/c/2387/4/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/CachedPage.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/CachedPage.java: PS4, Line 221: This method is uninterrubtible why? -- To view, visit https://asterix-gerrit.ics.uci.edu/2387 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28d57a222f42962284b24296cb9b91658e5dc77 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
