Xikui Wang has posted comments on this change. Change subject: Allow BAD jobs to update their specifications to use new indexes ......................................................................
Patch Set 5: (6 comments) Added more comments. https://asterix-gerrit.ics.uci.edu/#/c/2620/5/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADStatementExecutor.java: Line 143: throws CompilationException, AlgebricksException { see my comments at patch set 3. Feel free to discuss with me if you need. https://asterix-gerrit.ics.uci.edu/#/c/2620/5/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DeployedJobSpecEventListener.java File asterix-bad/src/main/java/org/apache/asterix/bad/metadata/DeployedJobSpecEventListener.java: Line 137: rm this Line 169: this.state = newState; notify all here PS5, Line 190: public void waitForNonSuspendedState() throws InterruptedException { : while (state == ActivityState.SUSPENDED) { : this.wait(); : } : } : : private void waitForInactiveState() throws InterruptedException { : while (isActive()) { : this.wait(); : } : } change this to waitForState(parameter) and pass in the state. Line 202: public void suspend() throws HyracksDataException, InterruptedException { method synchronized? Please beware of deadlocks. Add test unit cases for this... Line 214: synchronized (this) { two synchronized? -- To view, visit https://asterix-gerrit.ics.uci.edu/2620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0a4d37a5b91063fcb1673dbfd008c140ed54ae6 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
