Xikui Wang has posted comments on this change. Change subject: Allow BAD jobs to update their specifications to use new indexes ......................................................................
Patch Set 5: (1 comment) a minor suggestion about the test case. :) https://asterix-gerrit.ics.uci.edu/#/c/2620/9/asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java File asterix-bad/src/test/java/org/apache/asterix/bad/test/BADListenerTest.java: Line 33 This test case doesn't cover what you would want to test. A good test example would be: 1. ThreadA notifies listener with STARTED (active now) 2. ThreadB tries to suspend, then ThreadA notifies FINISHED (B wait until A notifies finish, suspended now) 3. ThreadA waitAtSuspend, then ThreadB tries to resume, then ThreadA continues. This could capture the lifecycle that you are managing in the upsert case. -- To view, visit https://asterix-gerrit.ics.uci.edu/2620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0a4d37a5b91063fcb1673dbfd008c140ed54ae6 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
