Xikui Wang has posted comments on this change. Change subject: Redeploy channels and procedures during recovery ......................................................................
Patch Set 11: (4 comments) Several more follow-ups... We should be able to push it in in next round... https://asterix-gerrit.ics.uci.edu/#/c/2641/5/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java File asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java: PS5, Line 92: lusterStateManager().refreshState(); : } catch (Exception e) { : throw HyracksDataException.create(e); : } : } : : private void deployJobs(ICcApplicationContext appCtx, Lis > Done sorry that I didn't explain my comment very well. What I meant is that it seems to me that the getChannels and getAllPredures can be done within the previous txn. Is the 2nd txn necessary? Line 125: metadataProvider = new MetadataProvider(appCtx, MetadataBuiltinEntities.DEFAULT_DATAVERSE); > yes the followup question is the system now is in suspend state right? Would it be a problem for the later execution? (It's never resumed. My observation from reading codes the job run will overwrite the state immediately...) PS5, Line 161: LOGGER.log(Level.SEVERE, entityId.getExtensionName() + " " + entityId.ge > Sure. We can talk about it more in future, but the main issue is: In other word, we are not storing the period of the repetitive procedures? I guess for the non-repetitive case, deploy the job spec should be good enough I guess... https://asterix-gerrit.ics.uci.edu/#/c/2641/11/asterix-bad/src/test/resources/recoveryts/queries/recovery/check_channels/check_channels.3.sleep.sqlpp File asterix-bad/src/test/resources/recoveryts/queries/recovery/check_channels/check_channels.3.sleep.sqlpp: Line 25: 25000 why sleep 25 seconds? (This will make the bad test longer for every patch right?...) -- To view, visit https://asterix-gerrit.ics.uci.edu/2641 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
