Steven Jacobs has posted comments on this change. Change subject: Redeploy channels and procedures during recovery ......................................................................
Patch Set 5: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2641/5/asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java File asterix-bad/src/main/java/org/apache/asterix/bad/recovery/BADGlobalRecoveryManager.java: PS5, Line 92: tionContext mdTxnCtx = MetadataManager.INSTANCE.beginTransaction(); : metadataProvider.setMetadataTxnContext(mdTxnCtx); : : List<Channel> channels = BADLangExtension.getAllChannels(mdTxnCtx); : List<Procedure> procedures = BADLangExtension.getAllProcedures(mdTxnCtx); : : MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); > sorry that I didn't explain my comment very well. What I meant is that it s Done Line 125: listener.suspend(); > the followup question is the system now is in suspend state right? Would it the redeployJobSpec call (line 127) calls listener.resume() at the end. PS5, Line 161: //Issue: need to store in metadata the information for running instances > In other word, we are not storing the period of the repetitive procedures? We do store the period, but just having the period doesn't give us any guarantees about whether there were actually instances of the procedure running or not. In other words, you can create a repetitive procedure but not execute it. There is a deeper question about maintaining multiple instances of repetitive procedures as well, which is why this is listed as TODO -- To view, visit https://asterix-gerrit.ics.uci.edu/2641 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6897ccf9cddb9ec8d10256e252ee893afe6db145 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
