Luo Chen has posted comments on this change. Change subject: [NO ISSUE] Report all BufferCache write failures. ......................................................................
Patch Set 5: (3 comments) A few minor comments... https://asterix-gerrit.ics.uci.edu/#/c/2787/5/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java: PS5, Line 1195: @Override : public void writeFailed(ICachedPage page, Throwable failure) { : if (this.failure == null) { : this.failure = failure; : } : } : : @Override : public boolean hasFailed() { : return failure != null; : } : : @Override : public Throwable getFailure() { : return failure; : } Is it possible to extract a common abstract bulkloader class for this purpose, as we did for index cursors.. https://asterix-gerrit.ics.uci.edu/#/c/2787/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexWithBuddyBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IndexWithBuddyBulkLoader.java: PS5, Line 85: getFailure What if both bulkloaders have failed? This method should only return any failure, or both failures? https://asterix-gerrit.ics.uci.edu/#/c/2787/5/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IFIFOPageQueue.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IFIFOPageQueue.java: PS5, Line 18: // Isn't a queue FIFO by default? rename to IPageWriteQueue? I don't think all I/O queues are FIFO by default. For example, the OS can reorder disk read/write requests in the queue to minimize random I/Os... FIFO here seems to emphasize the fact that the queue is FIFO (but I fine with either name) -- To view, visit https://asterix-gerrit.ics.uci.edu/2787 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97fd3dccff85dab84d644359be6f66b15ee708ef Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
