abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE] Report all BufferCache write failures. ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2787/5/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java: PS5, Line 1195: @Override : public void writeFailed(ICachedPage page, Throwable failure) { : if (this.failure == null) { : this.failure = failure; : } : } : : @Override : public boolean hasFailed() { : return failure != null; : } : : @Override : public Throwable getFailure() { : return failure; : } > Is it possible to extract a common abstract bulkloader class for this purpo Okay... after spending some time looking into this, it is not very obvious. It could be done for the on single component items (btree, rtree, inverted, bloom) however, it is trickier to do for lsm bulkloaders. I did the easy part and maybe we can revisit the difficult one. -- To view, visit https://asterix-gerrit.ics.uci.edu/2787 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97fd3dccff85dab84d644359be6f66b15ee708ef Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
