Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1002: Fix exception handling in EmptyTupleSourceRuntimeFactory ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/416/1/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java: Line 61: } > Great idea to close the writer in a finally! The catch was intended for the exception thrown by the flush not the illegalState :) But you are right, since we are not doing anything in the catch-block, unlike other operators where the close is done there, it should be removed. -- To view, visit https://asterix-gerrit.ics.uci.edu/416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc9da24ceca87c6a8ec4bae16a0579312c27b668 Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
