Murtadha Hubail has submitted this change and it was merged. Change subject: ASTERIXDB-1002: Fix exception handling in EmptyTupleSourceRuntimeFactory ......................................................................
ASTERIXDB-1002: Fix exception handling in EmptyTupleSourceRuntimeFactory Change-Id: Ibc9da24ceca87c6a8ec4bae16a0579312c27b668 Reviewed-on: https://asterix-gerrit.ics.uci.edu/416 Tested-by: Jenkins <[email protected]> Reviewed-by: Till Westmann <[email protected]> --- M algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified diff --git a/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java b/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java index b5d717a..5b66736 100644 --- a/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java +++ b/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/EmptyTupleSourceRuntimeFactory.java @@ -49,13 +49,15 @@ @Override public void open() throws HyracksDataException { writer.open(); - if (!appender.append(tb.getFieldEndOffsets(), tb.getByteArray(), 0, tb.getSize())) { - throw new IllegalStateException(); + try { + if (!appender.append(tb.getFieldEndOffsets(), tb.getByteArray(), 0, tb.getSize())) { + throw new IllegalStateException(); + } + appender.flush(writer, true); + } finally { + writer.close(); } - appender.flush(writer, true); - writer.close(); } }; } - } -- To view, visit https://asterix-gerrit.ics.uci.edu/416 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9da24ceca87c6a8ec4bae16a0579312c27b668 Gerrit-PatchSet: 3 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]>
