Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1045: Log analysis fixes ......................................................................
Patch Set 12: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/289/12/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java: Line 34: public class LogReader implements ILogReader { on unrelated note to the change. Just add a comment that this class is not to be used by multithreads since it is sharing the same variables between next() and read() Line 171: } Lets add a print statement (System.out.println("waiting for IO on file " + fileName)) and a thread sleep here to verify that the build failures are not caused by the busy waiting. -- To view, visit https://asterix-gerrit.ics.uci.edu/289 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
