Young-Seok Kim has posted comments on this change. Change subject: ASTERIXDB-1045: Log analysis fixes ......................................................................
Patch Set 14: (4 comments) Please address comments. https://asterix-gerrit.ics.uci.edu/#/c/289/14/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java File asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java: Line 160: if(buffer.remaining() < (Integer.SIZE + Byte.SIZE)/Byte.SIZE) { better be defining constants such as LOG_TYPE_SIZE, JOB_ID_SIZE. Also, below all the size related stuff can be replaced with appropriately defined Constants. https://asterix-gerrit.ics.uci.edu/#/c/289/14/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java: Line 105: } what if the record's status is BAD_CHKSUM? Also, below, we should distinguish the return value for BAD_CHKSUM and TRUNCATED since truncated seems a legal state, but BAD_CHKSUM in any case should be considered as illegal state, right? So, truncated case can return null, but bad-chksum should throw exception, right? Line 172: read = fileChannel.read(readBuffer); Can we explain briefly the read() method behavior so that code reader understands why we do this? Line 220: eof = refillLogReadBuffer(); should be eof = !refillLogReadBuffer(); instead of eof = refillLogReadBuffer(); -- To view, visit https://asterix-gerrit.ics.uci.edu/289 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
