Ian Maxon has posted comments on this change. Change subject: Adding 'cleanjson' output format, along with implementation of lists. ......................................................................
Patch Set 7: Code-Review+1 (3 comments) Just a few nits https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java: Line 76: LOGGER.warning("LOSSLESS_JSON exception in parsing message " + message + " exception [" + jse.getMessage() + "]"); s/JSON/LOSSLESS_JSON/g isn't quite right here :) https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java: Line 76: LOGGER.warning("LOSSLESS_JSON Exception in parsing message " + message); Ditto... https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java File asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java: Line 67: Can getJSONPrinterFactoryProvider be changed to getLosslessJSONPrinterFactoryProvider? -- To view, visit https://asterix-gerrit.ics.uci.edu/361 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c37d3b5aad7f286eba1cb8cb5f05ad456a6521c Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
