Chris Hillery has posted comments on this change. Change subject: Adding 'cleanjson' output format, along with implementation of lists. ......................................................................
Patch Set 7: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java File asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java: Line 95: // If it's LOSSLESS_JSON, check for the "lossless" flag > Just "JSON" Done https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedMessageService.java: Line 76: LOGGER.warning("LOSSLESS_JSON exception in parsing message " + message + " exception [" + jse.getMessage() + "]"); > s/JSON/LOSSLESS_JSON/g isn't quite right here :) Done https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/message/FeedMessageService.java: Line 76: LOGGER.warning("LOSSLESS_JSON Exception in parsing message " + message); > Ditto... Done https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java File asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java: Line 206: // QQQ For now, we are indeed assuming we get back LOSSLESS_JSON errors. > Just 'JSON' Done https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java File asterix-om/src/main/java/org/apache/asterix/formats/base/IDataFormat.java: Line 66: public IPrinterFactoryProvider getJSONPrinterFactoryProvider(); > Change to getLossless...() Done Line 67: > Can getJSONPrinterFactoryProvider be changed to getLosslessJSONPrinterFacto Done https://asterix-gerrit.ics.uci.edu/#/c/361/7/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlJSONPrinterFactoryProvider.java File asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlJSONPrinterFactoryProvider.java: Line 61: public class AqlJSONPrinterFactoryProvider implements IPrinterFactoryProvider { > Rename to AqlLosslessJSON... Done -- To view, visit https://asterix-gerrit.ics.uci.edu/361 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c37d3b5aad7f286eba1cb8cb5f05ad456a6521c Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
