Young-Seok Kim has posted comments on this change.

Change subject: ASTERIXDB-1045: Log analysis fixes
......................................................................


Patch Set 14:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/289/14/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java
File 
asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java:

Line 105:                 }
> No, we shouldn't ever throw a runtime exception here. All that should happe
I think we should let user know about the status about the system when the 
recovery sees bad checksum. Otherwise, it will be considered as a normal 
recovered state, right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/289
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1658e938eb0f199f748407361ffee4833aac661c
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Young-Seok Kim <[email protected]>
Gerrit-HasComments: Yes

Reply via email to