Ildar Absalyamov has posted comments on this change. Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory allocation ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java File asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java: Line 213: System.out.println("None JSON Error Mesesage : " + errorBody); Could this exception instead be rethrown upwards with a proper message? In cluster setup who know where would stdout be redirected? On the other hand the callsite already manages to properly log the thrown exception -- To view, visit https://asterix-gerrit.ics.uci.edu/408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
