Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory allocation ......................................................................
Patch Set 6: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: Line 279: assert vbcs != null; asserts have a few disadvantages: 1) they need to be enabled to actually be used and 2) when they fails they are usually not handled well if at all. Could we either remove this or replace it with a real exception? Line 607: throw new HyracksDataException("Failed to deallocate memory for dataset with ID " + datasetId s/deallocate/allocate/ Line 625: dsInfo.memoryAllocated = true; It would be nice, if "memoryAllocated" (and all other fields) would be part of the toString() for DatasetInfo to ease debugging. Line 648: @Override If this method disappears from the IIndexLifecycleManager, we don't need it here anymore. Line 665: //This method is currently never used but it is implemented in case of memory management design change. ditto https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java: Line 142: @Override If this method disappears from the IIndexLifecycleManager, we don't need it here anymore. Line 147: @Override ditto -- To view, visit https://asterix-gerrit.ics.uci.edu/408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
