Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-976: CSV support for all basic types ......................................................................
Patch Set 2: Code-Review+2 True, if we want to fix those it would be good. It is a bigger problem though, there are just a ton of places in the code where we rely on local assumptions about the specific object format (i.e. seeking to specific offsets, and so on), rather than having it abstracted out somehow. What had to be done for Jianfeng's variable length encoding patch highlights the issue pretty well. -- To view, visit https://asterix-gerrit.ics.uci.edu/444 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a515efd2bbf25895537413b45eb0992484c7412 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: No
