Chris Hillery has posted comments on this change. Change subject: ASTERIXDB-976: CSV support for all basic types ......................................................................
Patch Set 2: All the comments about magic constants 1, 9, 17, 25, etc... I actually don't know for sure as I simply copied that part of the code from elsewhere, but I'm pretty sure it's just 1 byte for the type indicator and then multiples 8 bytes for the binary-serialized Doubles. I'm not sure we need a constant to represent 8 bytes being the size of a double, although it may be clearer. -- To view, visit https://asterix-gerrit.ics.uci.edu/444 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a515efd2bbf25895537413b45eb0992484c7412 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: No
