Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory allocation ......................................................................
Patch Set 11: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/408/11/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java File asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java: Line 60: * creates (if necessary) and returns the dataset info. > WS Done Line 76: * creates (if necessary) and returns the primary index operation tracker of a dataset. > WS Done Line 83: * creates (if necessary) and returns the dataset virtual buffer caches. > WS Done https://asterix-gerrit.ics.uci.edu/#/c/408/11/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java: Line 180: } > Maybe a mockito mock-object would be easier here? mocked. -- To view, visit https://asterix-gerrit.ics.uci.edu/408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
