Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory 
allocation
......................................................................


Patch Set 12: Code-Review+1

(2 comments)

Looks good to me.

Thinking a bot more I'm wondering how we could test that the memory allocation 
behavior is what we expect it to be. But as far as I know there is not way to 
get an insight into memory allocation/usage from the outside. Is that right? Or 
is there an easy way to get this information?

https://asterix-gerrit.ics.uci.edu/#/c/408/12/asterix-transactions/pom.xml
File asterix-transactions/pom.xml:

Line 120:       
new tab :)


https://asterix-gerrit.ics.uci.edu/#/c/408/12/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java
File 
asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/TestRuntimeContextProvider.java:

Line 43:     
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/408
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Carey <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Young-Seok Kim <[email protected]>
Gerrit-HasComments: Yes

Reply via email to