Till Westmann has posted comments on this change. Change subject: Improvment on Cursor for Delimited Data ......................................................................
Patch Set 2: (4 comments) Just a few comments/questions. https://asterix-gerrit.ics.uci.edu/#/c/567/2/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: Line 87: public String getRecordInfo() { It seems that this method is never used. Is this a debugging method? If so, would it make sense to call it toString() so that the debugger would use it? Line 392: public void setInputStream(Reader reader, char[] buffer) { It seems that these methods are not used. Can we remove them? Line 395: hasBuffer = true; Is the buffer truly set if somebody passes in null? https://asterix-gerrit.ics.uci.edu/#/c/567/2/pom.xml File pom.xml: Line 177: <exclude>**/*.project</exclude> I think that we don't need the "*" in front of ".classpath" and ".project". Is that right? -- To view, visit https://asterix-gerrit.ics.uci.edu/567 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84ff40db664633c633277e9cc0ffa534cda9f26a Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
