abdullah alamoudi has posted comments on this change. Change subject: Improvment on Cursor for Delimited Data ......................................................................
Patch Set 2: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/567/2/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: Line 87: public String getRecordInfo() { > It seems that this method is never used. Is this a debugging method? If so, I am not sure why this was added here since this was long time ago. I will remove it. Line 392: public void setInputStream(Reader reader, char[] buffer) { > It seems that these methods are not used. Can we remove them? I will remove this one. It was used to take care of a particular case which is taken care of now by some other mechanism :) Line 395: hasBuffer = true; > Is the buffer truly set if somebody passes in null? This method will be removed and also the method below as well. https://asterix-gerrit.ics.uci.edu/#/c/567/2/pom.xml File pom.xml: Line 177: <exclude>**/*.project</exclude> > I think that we don't need the "*" in front of ".classpath" and ".project". I think you're right. I will fix it now. -- To view, visit https://asterix-gerrit.ics.uci.edu/567 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84ff40db664633c633277e9cc0ffa534cda9f26a Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
