Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1187 and ASTERIXDB-1162 fixes, as well as updates on
the internal functions
......................................................................
Patch Set 17: Code-Review+1
(1 comment)
Looks good to me. Thanks for addressing the previous comments.
1. Just one object-creation issue in SimilarityEvaluator that needs to be
fixed, as inlined in the code.
2. Rephrase the commit message:
2.1 remove "- Addresses the issues rised from last reviews" because that
will appear as an atomic commit message on github;
2.2 "Updated the fix to address the issue ASTERIXDB-1162" --> "Fixes for
ASTERIXDB-1162".
https://asterix-gerrit.ics.uci.edu/#/c/298/17/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java
File
asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java:
Line 231: IBinaryHashFunction putHashFunc =
listItemBinaryHashFunctionFactory.createBinaryHashFunction(buildItemTypeTag,
There is per-tuple-based object creation here.
You can put those as class members and try to reuse them if they are not
changed, or use an object pool if they change from time to time.
The simple checking rule is that "there is per-call-based 'new' in
evaluate(IFrameTupleReference tuple) and its calling tree."
--
To view, visit https://asterix-gerrit.ics.uci.edu/298
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Heri Ramampiaro <[email protected]>
Gerrit-Reviewer: Heri Ramampiaro <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>
Gerrit-Reviewer: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes
