Heri Ramampiaro has posted comments on this change. Change subject: ASTERIXDB-1187 and ASTERIXDB-1162 fixes, as well as updates on the internal functions ......................................................................
Patch Set 17: (1 comment) Thanks, I will upload a new patch as soon as the tests are passed. https://asterix-gerrit.ics.uci.edu/#/c/298/17/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java: Line 231: IBinaryHashFunction putHashFunc = listItemBinaryHashFunctionFactory.createBinaryHashFunction(buildItemTypeTag, > There is per-tuple-based object creation here. I see your point. For simplicity, though, I'll revert to the original version from the master to avoid cascading changes and so on... -- To view, visit https://asterix-gerrit.ics.uci.edu/298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
