Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-944: added an AQL function that prints internal data format ......................................................................
Patch Set 4: (3 comments) There are some per-tuple-based object creation issues in AdmToBytesFactory that need to be fixed. https://asterix-gerrit.ics.uci.edu/#/c/523/4/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AdmToBytesFactory.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AdmToBytesFactory.java: Line 122: visitor = new AdmToBytesVisitor(admToBytesHelper, outputLevel); per-tuple-based object creation. Line 127: Triple<IAType, RuntimeRecordTypeInfo, Long> arg = new Triple<>(outputType, Could this lead to per-tuple-based object creation? Line 165: StringBuilder sb = new StringBuilder(); per-tuple-based object creation. -- To view, visit https://asterix-gerrit.ics.uci.edu/523 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31d0b2ec2d8686531833811937596c3dca660b1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
