Heri Ramampiaro has posted comments on this change. Change subject: ASTERIXDB-944: A new AQL function that prints internal data format ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/523/5/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AdmToBytesFactory.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AdmToBytesFactory.java: Line 173: return Long.parseLong(tempStringBuilder.toString()); > The toString call still creates a new string object every time. The main idea is to allow for "adm-to-bytes($r1, "3")" as equivalent to "adm-to-bytes($r1, 3)". The user would for most cases uses the later, so I did not think this would be an issue. However, I changed so that we do not need to deserialize the string first... -- To view, visit https://asterix-gerrit.ics.uci.edu/523 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31d0b2ec2d8686531833811937596c3dca660b1e Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
