Till Westmann has posted comments on this change. Change subject: Add flush() to IFrameWriter ......................................................................
Patch Set 5: I've got another question: It seems that close() usually is flush() + something. Not I'm wondering if we should also write it that way, i.e. call flush() in close() whenever close() contains the flush() functionality. Of course that would introduce another method call (and it's probably not inlined), but I think that it would make the relationship between flush() and close() clearer. Thoughts? -- To view, visit https://asterix-gerrit.ics.uci.edu/584 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85424bab7965b71aac709280af066e1655457aa3 Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
