Till Westmann has posted comments on this change. Change subject: Add flush() to IFrameWriter ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/584/5/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IFrameAppender.java File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IFrameAppender.java: Line 58: void write(IFrameWriter outWriter, boolean clear) throws HyracksDataException; The javadoc comments for write and flush don't align very well with the method names. -- To view, visit https://asterix-gerrit.ics.uci.edu/584 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85424bab7965b71aac709280af066e1655457aa3 Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
