abdullah alamoudi has posted comments on this change. Change subject: Add flush() to IFrameWriter ......................................................................
Patch Set 7: (10 comments) https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java: Line 269: try { > revert this file. Done https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRawRecord.java File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRawRecord.java: Line 56: public void set(T t); > rename t to record Done https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LookupAdapter.java: Line 165: appender.flush(writer, true); > check count > 0 Done https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCollector.java File asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCollector.java: Line 162: frameWriter.flush(); > just call flush() Done https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-external-data/src/main/java/org/apache/asterix/external/feed/watch/StorageSideMonitoredBuffer.java File asterix-external-data/src/main/java/org/apache/asterix/external/feed/watch/StorageSideMonitoredBuffer.java: Line 42: // seconds > invalid comment Done https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java: Line 113: public void append(String string) { > Unused method. Done https://asterix-gerrit.ics.uci.edu/#/c/585/7/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMeta.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/RecordWithMeta.java: Line 45: public class RecordWithMeta<T> { > Rename to RecordWithMetadata Done Line 77: public RecordWithMeta(IAType[] metaTypes, Class<? extends T> recordClass) throws HyracksDataException { > Remove throws Done Line 96: public ArrayBackedValueStorage get(int i) { > change the name of this method Done Line 111: public void setMeta(int i, int value) throws IOException { > rename to setMetadata and rename i to index. You may refactor these method Done -- To view, visit https://asterix-gerrit.ics.uci.edu/585 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id862ce9e9b1360864c6976f2aea2137092f51203 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
