Ian Maxon has posted comments on this change. Change subject: Add flush() to IFrameWriter ......................................................................
Patch Set 9: (3 comments) Few thoughts, but is the preliminary change feed stuff suppose to be in here? https://asterix-gerrit.ics.uci.edu/#/c/585/9/asterix-external-data/pom.xml File asterix-external-data/pom.xml: Line 279: </dependency> Are these MIT licensed? And do the POMs have the correct metadata about the LICENSE so it gets appended to this jar's LICENSE? Also we will have to add these to the LICENSE and NOTICE for asterix-server, installer, and yarn. https://asterix-gerrit.ics.uci.edu/#/c/585/9/asterix-external-data/src/main/java/org/apache/asterix/external/feed/message/MessageReceiver.java File asterix-external-data/src/main/java/org/apache/asterix/external/feed/message/MessageReceiver.java: Line 83: try { Why is polling and then calling emptyInbox() necessary here? https://asterix-gerrit.ics.uci.edu/#/c/585/9/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java File asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java: Line 570: if (recType != null) { Why is datasetRec not necessary anymore? -- To view, visit https://asterix-gerrit.ics.uci.edu/585 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id862ce9e9b1360864c6976f2aea2137092f51203 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
