Preston Carman has posted comments on this change. Change subject: Fixed Admin Console pages. ......................................................................
Patch Set 2: (2 comments) Thanks for pushing a new update. Although a few comment were not addressed. https://asterix-gerrit.ics.uci.edu/#/c/557/2//COMMIT_MSG Commit Message: Line 1: Parent: eea815d3 (Pass resource partition id to IModificationOperationCallback) Change the commit messege to be somthing like this: ASTERIXDB-1287: Fixed Admin Console pages. Previously the job details page of the admin console was not working correctly. Now It is fixed. Also fixed some internal issues like wrong time shown. - Removed configuration parameter in CCConfig which determines the interval of cluster data gathering in asterix. - Now JSON data in adminconsole for Job Details is shown in tabular form. - Previously, in job details page of admin console, all the data was shown in raw JSON format. Now using a MIT licensed js library, it is shown in tabular form. - Added Headers for the data shown in Index page of adminconsole. - Previously in job summary, create time, start time and end time was never updated. As a result they all were 0. Fixed it. - In adminconsole's Index page, the job create time, start time and end time all were being assigned with create time. Fixed it. - The same problem was also present in the REST API as well. Also fixed it. - Showing a message in job details page in admin console for jobs that were deleted because the maximum size of job archive was reached. - Added a configuration parameter in CCConfig which determines the interval of cluster data gathering in asterix. - Beautified the job details page in adminconsole by adding tabs. - Fixed the job details page in adminconsole. Previously it was broken. Now it shows the raw JSON data sent to it. - Optimized the node details information sent by the adminconsole API. Previously, the API was sending the full array everytime even though the whole array was not full. As a result, there were many instances with no data. Now its sending only the subarrays that actually contains data. Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540 https://asterix-gerrit.ics.uci.edu/#/c/557/2/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java: Line 289: o.put("heartbeat-times", Arrays.copyOfRange(hbTime, 0, rrdPtr)); Please address Ian's comment about the array copy. Why is this needed? -- To view, visit https://asterix-gerrit.ics.uci.edu/557 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-HasComments: Yes
