Pritom Ahmed has posted comments on this change. Change subject: Fixed Admin Console pages. ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/557/2/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java: Line 289: o.put("heartbeat-times", Arrays.copyOfRange(hbTime, 0, rrdPtr)); > Please address Ian's comment about the array copy. Why is this needed? We can also use ArrayUtils.subarray(...) method to have the same effect.Done -- To view, visit https://asterix-gerrit.ics.uci.edu/557 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-HasComments: Yes
