Steven Jacobs has posted comments on this change. Change subject: Equivalence induced onetoone operatiions for insert/delete/upsert/query exchange optimization for lookup and delete when the operation is merely directed by the primary key. ......................................................................
Patch Set 9: (5 comments) A few comments. https://asterix-gerrit.ics.uci.edu/#/c/427/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/ProducedVariableExpressionVisitor.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/ProducedVariableExpressionVisitor.java: Line 66: */ Wrong author here? https://asterix-gerrit.ics.uci.edu/#/c/427/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java: Line 86: if (-1 != partition) Just a stylistic thing here: I think this is better as "partition != -1" https://asterix-gerrit.ics.uci.edu/#/c/427/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java: Line 80: if (-1 != partition) Same here https://asterix-gerrit.ics.uci.edu/#/c/427/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/OrderedPartitionedProperty.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/OrderedPartitionedProperty.java: Line 92: whitespace https://asterix-gerrit.ics.uci.edu/#/c/427/9/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: Line 292: if (null != rqd.getPartitioningProperty() && rqd.getPartitioningProperty().isSingle()) { Style again, should be "rgd... != null" -- To view, visit https://asterix-gerrit.ics.uci.edu/427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic836210e57b87128120e1f8dabbfed062d09f5e4 Gerrit-PatchSet: 9 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
