Steven Jacobs has posted comments on this change. Change subject: Equivalence induced onetoone operatiions for insert/delete/upsert/query exchange optimization for lookup and delete when the operation is merely directed by the primary key. ......................................................................
Patch Set 9: (1 comment) One bonus comment after looking at Asterix. It seems like IsSinglePartition isn't actually needed Steven https://asterix-gerrit.ics.uci.edu/#/c/427/9/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IndexInsertDeleteUpsertPOperator.java: Line 61: After looking at Asterix, I think the same comment applies here. Do we actually need "isSinglePartition" or can we just check by "partitionId == -1" -- To view, visit https://asterix-gerrit.ics.uci.edu/427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic836210e57b87128120e1f8dabbfed062d09f5e4 Gerrit-PatchSet: 9 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
