Till Westmann has posted comments on this change. Change subject: Update the Key Value Reader ......................................................................
Patch Set 2: (4 comments) A few questions. https://asterix-gerrit.ics.uci.edu/#/c/805/2/asterixdb/asterix-external-data/pom.xml File asterixdb/asterix-external-data/pom.xml: Line 296: </dependency> Why is the order different now? Should just be the version number, right? https://asterix-gerrit.ics.uci.edu/#/c/805/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/kv/KVReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/kv/KVReader.java: Line 99: this.pushThread = new Thread(new Runnable() { Should this use some ThreadPool? Line 102: KVReader.this.run(connection); How do we cleanly stop this thread? Line 113: connection.subject().takeUntil(Observable.never()).toBlocking().forEach(new Action1<DCPRequest>() { * Isn't takeUntil(Observable.never()) redundant? -- To view, visit https://asterix-gerrit.ics.uci.edu/805 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f8a313c871428b2468b74c0760e8d28e810699 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
