abdullah alamoudi has posted comments on this change. Change subject: Update the Key Value Reader ......................................................................
Patch Set 2: What the is contract for IRecordReader? until hasNext() returns false, we try to read more. I'm asking as RecordWithMetaTest seems to suggest that reading stops when hasNext returns false. That is true. However, for KVReader it is not clear to me how repeatedly calling next() will cause hastNext to return "false" as some point. I don't think we keep calling next() repeatedly. What made you think that? For KV Reader, it will keep waiting for more data until the connection is closed from the other side or the feed is disconnected within asterix. this basically will set done = true and hasNext() will return false. Note that within feeds, we ignore Null. getting Null as a record then means that the reader hasNext() but it is not ready yet. -- To view, visit https://asterix-gerrit.ics.uci.edu/805 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f8a313c871428b2468b74c0760e8d28e810699 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
