Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/29#issuecomment-143243404
Basically, I shared with @nickva my thoughts yesterday:
https://www.friendpaste.com/1i7prAWoYDl5YcWDaAiDuS - I don't like it because of
dirty -1 usage and that params validation happens during parse stage.
Another approach is to reuse `Args#mrargs.extra` to handle fact of having
`group=true|false` and put all group/group_level validation into validate_args
function. That will keep us from changing record without a serious reason and
we'll continue maintain only a single validation function.
Here we have changed record and two function in different modules that
validates Args. That's horrible, imho.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
