Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/29#issuecomment-143245617
One of the functions was added for clarity. It looks better than a long
case statement, I think. It makes it clear what happening there. The case
statement in the paste was hard for me to figure out.
The additional field to the record, seemed simpler than re-writing the
whole parse_parm(s) function, say have another private record or dict to
accumulate params, then create #mrargs from it, etc.
In general two step validation (here and in _util) is ok, as it seems one
is simpler, and the other one tests more in depth (like are conflicts invalid
for reduce view etc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
