[
https://issues.apache.org/jira/browse/COUCHDB-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956790#comment-14956790
]
ASF GitHub Bot commented on COUCHDB-769:
----------------------------------------
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/82#discussion_r41984976
--- Diff: src/chttpd_db.erl ---
@@ -733,7 +741,17 @@ db_doc_req(#httpd{method='POST', user_ctx=Ctx}=Req,
Db, DocId) ->
NewDoc = Doc#doc{
atts = UpdatedAtts ++ OldAtts2
},
- case fabric:update_doc(Db, NewDoc, Options) of
+ couch_log:debug("chttpd_db: couchNew doc formed including new att:
formed",[]),
+ lists:foreach(fun(X) -> couch_log:debug("~p~n
~p~n",[couch_att:fetch(data, X), couch_att:fetch(name, X)]) end,
NewDoc#doc.atts),
+ couch_log:debug("chttpd_db: going to call attachment handler for
base64 attachments",[]),
+ case fabric_attachments_handler:externalize_att(Db) of
+ "true" ->
+ NewNewDoc = fabric_attachments_handler:inline_att_store(Db,
NewDoc); %store_single_document
+ "false" ->
+ couch_log:debug("Store inline attachmets in Swift
disabled",[]),
+ NewNewDoc = NewDoc
--- End diff --
Better not assign variable in case, but assign case result to variable.
> Store large attachments external to the .couch file
> ---------------------------------------------------
>
> Key: COUCHDB-769
> URL: https://issues.apache.org/jira/browse/COUCHDB-769
> Project: CouchDB
> Issue Type: New Feature
> Components: Database Core
> Reporter: Robert Newson
> Assignee: Adam Kocoloski
> Attachments: external_attachments_alpha.patch
>
>
> For attachment-heavy applications storing the attachments in separate files
> significantly eases compaction problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
