[ 
https://issues.apache.org/jira/browse/COUCHDB-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956792#comment-14956792
 ] 

ASF GitHub Bot commented on COUCHDB-769:
----------------------------------------

Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-chttpd/pull/82#discussion_r41985112
  
    --- Diff: src/chttpd_db.erl ---
    @@ -733,7 +741,17 @@ db_doc_req(#httpd{method='POST', user_ctx=Ctx}=Req, 
Db, DocId) ->
         NewDoc = Doc#doc{
             atts = UpdatedAtts ++ OldAtts2
         },
    -    case fabric:update_doc(Db, NewDoc, Options) of
    +    couch_log:debug("chttpd_db: couchNew doc formed including new att: 
formed",[]),
    +    lists:foreach(fun(X) -> couch_log:debug("~p~n 
~p~n",[couch_att:fetch(data, X), couch_att:fetch(name, X)]) end, 
NewDoc#doc.atts),
    --- End diff --
    
    Please, don't do this: if document has a lot of attachments, this loop will 
spin without producing any useful work, but only slow down all around.


> Store large attachments external to the .couch file
> ---------------------------------------------------
>
>                 Key: COUCHDB-769
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-769
>             Project: CouchDB
>          Issue Type: New Feature
>          Components: Database Core
>            Reporter: Robert Newson
>            Assignee: Adam Kocoloski
>         Attachments: external_attachments_alpha.patch
>
>
> For attachment-heavy applications storing the attachments in separate files 
> significantly eases compaction problems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to