[
https://issues.apache.org/jira/browse/COUCHDB-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081101#comment-15081101
]
ASF GitHub Bot commented on COUCHDB-769:
----------------------------------------
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/33#discussion_r48727108
--- Diff: src/fabric_db_create.erl ---
@@ -164,6 +164,19 @@ make_document([#shard{dbname=DbName}|_] = Shards,
Suffix) ->
{[[<<"add">>, Range, Node] | Raw], orddict:append(Node, Range,
ByNode),
orddict:append(Range, Node, ByRange)}
end, {[], [], []}, Shards),
+
+ case fabric_att_handler:external_store() of
+ true ->
+ DbNameSuffix = unicode:characters_to_list(DbName) ++ Suffix,
+ case fabric_att_handler:container(create,DbNameSuffix) of
+ {ok, Container} ->
+ couch_log:debug("Container ~p created", [Container]);
+ {error,_} ->
+ couch_log:debug("Container ~p creation failed",
[DbNameSuffix])
--- End diff --
You don't handle an error by logging, surely this is fatal?
> Store large attachments external to the .couch file
> ---------------------------------------------------
>
> Key: COUCHDB-769
> URL: https://issues.apache.org/jira/browse/COUCHDB-769
> Project: CouchDB
> Issue Type: New Feature
> Components: Database Core
> Reporter: Robert Newson
> Assignee: Adam Kocoloski
> Attachments: external_attachments_alpha.patch
>
>
> For attachment-heavy applications storing the attachments in separate files
> significantly eases compaction problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
