[
https://issues.apache.org/jira/browse/COUCHDB-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081121#comment-15081121
]
ASF GitHub Bot commented on COUCHDB-769:
----------------------------------------
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/82#discussion_r48728194
--- Diff: src/chttpd_db.erl ---
@@ -407,7 +407,16 @@
db_req(#httpd{method='POST',path_parts=[_,<<"_bulk_docs">>], user_ctx=Ctx}=Req,
true -> [all_or_nothing|Options];
_ -> Options
end,
- case fabric:update_docs(Db, Docs, Options2) of
+ case fabric_att_handler:external_store() of
+ true ->
+ couch_log:debug("store attachment externaly", []),
+ NewDocs = fabric_att_handler:att_store(Db,
+
fabric:docs(Docs));
+ false ->
+ couch_log:debug("externalize attachment: disabled",[]),
+ NewDocs = Docs
+ end,
--- End diff --
It would be cleaner if the result of the case statement was assigned to
`NewDocs`. i.e, `NewDocs = case...`
> Store large attachments external to the .couch file
> ---------------------------------------------------
>
> Key: COUCHDB-769
> URL: https://issues.apache.org/jira/browse/COUCHDB-769
> Project: CouchDB
> Issue Type: New Feature
> Components: Database Core
> Reporter: Robert Newson
> Assignee: Adam Kocoloski
> Attachments: external_attachments_alpha.patch
>
>
> For attachment-heavy applications storing the attachments in separate files
> significantly eases compaction problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
