Github user chewbranca commented on the pull request:
https://github.com/apache/couchdb-couch/pull/138#issuecomment-190344092
@kxepal @iilyak @eiri @davisp in general I think the approach of deleting
`couch_httpd_cors` in favor of `chttpd_cors` is correct and is fine to do here.
The `chttpd_cors` implementation was based off of `couch_httpd_cors` with a
number of changes cleaning things up and improving the implementation. We
talked about whether to remove `couch_httpd_cors` in the past but the
`chttpd_cors` implementation did not support the same multi-host config format
that already existed, a problem @iilyak has rectified in this set of PRs, so in
general I'm +1 to this change.
For this PR, does it make sense to delete the CORS implementation but leave
in the CORS tests?
As for introducing a third `*_httpd` library layer, I think we would be
better off spending the time consolidating down to a single HTTP stack and
removing the current dichotomy as quickly as we can.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
