Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59884759
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
+get_selector({json_req, {Props}}) ->
+ check_selector(couch_util:get_value(<<"selector">>, Props));
+get_selector(#httpd{method='POST'}=Req) ->
+ couch_httpd:validate_ctype(Req, "application/json"),
+ {Props} = couch_httpd:json_body_obj(Req),
+ check_selector(couch_util:get_value(<<"selector">>, Props));
--- End diff --
The pattern that @kxepal is highlighting is to recurse to unwrap objects.
So your first clause has the base case, and the second clause would take out
the thing to be selected and then recurse to the same check. That way your
extraction logic is only written once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
