Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/162#discussion_r59886640
--- Diff: src/couch_changes.erl ---
@@ -336,6 +343,16 @@ get_doc_ids(_) ->
throw({bad_request, no_doc_ids_provided}).
+get_selector({json_req, {Props}}) ->
+ check_selector(couch_util:get_value(<<"selector">>, Props));
+get_selector(#httpd{method='POST'}=Req) ->
+ couch_httpd:validate_ctype(Req, "application/json"),
+ {Props} = couch_httpd:json_body_obj(Req),
+ check_selector(couch_util:get_value(<<"selector">>, Props));
+get_selector(_) ->
+ throw({bad_request, invalid_selector}).
--- End diff --
The spec (obviously) is not so clear. We could send 405 Method Not Allowed
but that's a resource-level thing and seems inappropriate. I'd send a 400 with
a clear message if ?selector param exists, as both kxepal and davisp suggest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
