Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/713#discussion_r65156934
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -111,7 +112,7 @@ var ToggleHeaderButton = React.createClass({
},
render: function () {
- var iconClasses = this.props.iconDefaultClass + ' ' +
this.props.fonticon + ' ' + this.props.innerClasses,
+ var iconClasses = `${this.props.iconDefaultClass}
${this.props.fonticon} ${this.props.innerClasses}`,
--- End diff --
using `const` here would be cool. Also there are quite a few string
concatenations in this function. I think we could use string templates to make
them more readable. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
