Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/713#discussion_r65165884
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -199,165 +205,102 @@ var AddFilterForm = React.createClass({
this.props.addFilter(this.state.filter);
this.setState({ filter: '', error: false });
}
- },
+ }
- componentDidMount: function () {
+ componentDidMount () {
this.focusFilterField();
- },
+ }
- componentDidUpdate: function () {
+ componentDidUpdate () {
this.focusFilterField();
- },
+ }
- focusFilterField: function () {
+ focusFilterField () {
ReactDOM.findDOMNode(this.refs.addItem).focus();
- },
-
- onChangeFilter: function (e) {
- this.setState({ filter: e.target.value });
- },
+ }
- inputClassNames: function () {
+ inputClassNames () {
var className = 'js-changes-filter-field';
--- End diff --
The rationale was that the `js-` prefixes would indicate the class only has
significance for the JS code - especially test code - and not be used for any
styling. It seemed a good idea at the time :)- but it is being used by a bunch
of tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
