Github user brkolla commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/70#discussion_r79918383
--- Diff: src/fabric_view.erl ---
@@ -308,6 +308,26 @@ get_shards(DbName, #mrargs{stale=Stale})
get_shards(DbName, #mrargs{stale=false}) ->
mem3:shards(DbName).
+maybe_update_others(DbName, DDoc, ShardsInvolved, ViewName,
#mrargs{stale=Stale} = Args)
+ when Stale == update_after ->
+ ShardsNeedUpdated = mem3:shards(DbName) -- ShardsInvolved,
+ lists:foreach(fun(#shard{node=Node, name=ShardName}) ->
+ rpc:cast(Node, fabric_view, maybe_update, [ShardName, DDoc,
ViewName, Args])
+ end, ShardsNeedUpdated).
+
+maybe_update(DbName, {DDocId, Rev}, ViewName, Args0) ->
+ {ok, Db} = case couch_db:open_int(DbName, []) of
+ {ok, _} = Resp -> Resp;
+ Else -> exit(Else)
--- End diff --
I copied that code from some other module. I am guessing that the intent of
that is to proceed further only if it succeeds opening a DB. Should I just
replace that with `{ok, Db} = case couch_db:open_int(DbName, [])`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
