[ 
https://issues.apache.org/jira/browse/COUCHDB-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746608#comment-15746608
 ] 

ASF GitHub Bot commented on COUCHDB-3255:
-----------------------------------------

GitHub user davisp opened a pull request:

    https://github.com/apache/couchdb-couch/pull/218

    Make revision generation deterministic

    This removes the influence of the attachment disk information when
    generating revisions when a document is being recreated (ie, it existed
    once but has been deleted).
    
    COUCHDB-3255

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch 
COUCHDB-3255-fix-new-revid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #218
    
----
commit 656967aa13b76e60806df040db0a92d164d96d72
Author: Paul J. Davis <[email protected]>
Date:   2016-12-13T23:30:46Z

    Make revision generation deterministic
    
    This removes the influence of the attachment disk information when
    generating revisions when a document is being recreated (ie, it existed
    once but has been deleted).
    
    COUCHDB-3255

----


> Conflicts introduced by recreating docs with attachments
> --------------------------------------------------------
>
>                 Key: COUCHDB-3255
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3255
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Paul Joseph Davis
>
> When a document is re-created with an attachment it receives a 
> non-deterministic revision.  This is due to a fairly old commit [1] that 
> introduced the behavior by accidentally including information about revisions 
> on disk into the revision id calculation when the revision id was being 
> calculated by couch_db_updater when it realized that the update was 
> re-creating a document that was previously deleted.
> I'm opening a PR with the fix.
> [1] 
> https://github.com/apache/couchdb-couch/commit/08a94d582cd3086ebcbd51ad8ac98ca6df98a1b7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to