[ 
https://issues.apache.org/jira/browse/COUCHDB-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751696#comment-15751696
 ] 

ASF subversion and git services commented on COUCHDB-3255:
----------------------------------------------------------

Commit 58382d441e5ed499dce5904229d176068c17a5bc in couchdb-couch's branch 
refs/heads/master from [~paul.joseph.davis]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=58382d4 ]

Make revision generation deterministic

This removes the influence of the attachment disk information when
generating revisions when a document is being recreated (ie, it existed
once but has been deleted).

Big thanks to @tonysun83 for getting a reproducer as well as the test
included with this PR.

COUCHDB-3255


> Conflicts introduced by recreating docs with attachments
> --------------------------------------------------------
>
>                 Key: COUCHDB-3255
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3255
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Paul Joseph Davis
>
> When a document is re-created with an attachment it receives a 
> non-deterministic revision.  This is due to a fairly old commit [1] that 
> introduced the behavior by accidentally including information about revisions 
> on disk into the revision id calculation when the revision id was being 
> calculated by couch_db_updater when it realized that the update was 
> re-creating a document that was previously deleted.
> I'm opening a PR with the fix.
> [1] 
> https://github.com/apache/couchdb-couch/commit/08a94d582cd3086ebcbd51ad8ac98ca6df98a1b7



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to